v1.19 - Moving embedded bit from offset to name in reflect and reflectlite#1250
Merged
nevkontakte merged 1 commit intogopherjs:go1.19from Nov 14, 2023
Merged
v1.19 - Moving embedded bit from offset to name in reflect and reflectlite#1250nevkontakte merged 1 commit intogopherjs:go1.19from
nevkontakte merged 1 commit intogopherjs:go1.19from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the reflect and reflectlite package to set the embedded flag as part of the Go 1.19 upgrade.
Commit e1e66a0 "move embedded bit from offset to name" changes how reflect and reflectlite store the embedded flag. The creation of the
nameand the creation forstructFieldis affected by this change for Go 1.19. Both are overwritten by GopherJS.