[go1.19] Updating natives #1262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5943b6d to
cbe21ec
Compare
9d0bfab to
a83c5fa
Compare
nevkontakte
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
All looks good, I'll wait until #1260 is merged and merge this one too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the updates to the native overrides to remove type parameters from the standard libraries as part of the generic-less go1.19.
There is more to still be done for natives, this just is part of the whole update. More will come later as we work our way through all the tests.
Dependencies:
gopherjs:override-signatureso won't function until [go1.19] Fix build issue and add override signature directive #1260 has been merged intogo1.19.