[go1.20] Updated gorepo test flag handling #1304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go file
go1.20.14:test/run.go
added more handling of the test flag arguments. Since some of the new tests for go1.20 use these flags, I updated the flag parsing into the GopherJS copy of the same runner,gorepo/run.go
. These updates are nearly identical copies of the code from the Go repo. Any deviations I've commented with a// GOPHERJS:
comment. This is part of #1270Other than being able to handle more flags, the only main change was adding the timeout flag ability. The comment in the timeout (i.e. "This command-timeout code adapted...") is from the original source code.
Here is an example of a test, fixedbugs/issue59334.go, failing prior to this update: