Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[go1.20] Pull master into go1.20#1308

Merged
nevkontakte merged 10 commits intogopherjs:go1.20from
Workiva:updateGo1.20
May 25, 2024
Merged

[go1.20] Pull master into go1.20#1308
nevkontakte merged 10 commits intogopherjs:go1.20from
Workiva:updateGo1.20

Conversation

@grantnelson-wf
Copy link
Collaborator

@grantnelson-wf grantnelson-wf commented May 23, 2024

Keeping go1.20 up-to-date with master

CI will still not pass because we haven't gotten go1.20 to pass yet.
This is part of #1270

grantnelson-wf and others added 10 commits April 25, 2024 13:59
Fixing internalization of null slice and array fields
Before this change, GopherJS compiler emitted `(f >> 0)` expression to
convert a float64 `f` to any non-64-bit unsigned integer type. This is
incorrect, because `>>` is a signed bitshift operator in JS, so the
returned value remained signed. Moreover, it did not take into account
to bit size of the target type.

By removing the switch cause, we make the compiler fall through to the
default clause where `fc.fixNumber()` actually does the right thing,
taking the target into account.

Fixes gopherjs#733.
Fix float64 to uint{8,16,32} conversion.
@nevkontakte nevkontakte merged commit 73958a0 into gopherjs:go1.20 May 25, 2024
@grantnelson-wf grantnelson-wf deleted the updateGo1.20 branch May 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants