[go1.20] Updating generics overrides for crypto#1312
Merged
nevkontakte merged 1 commit intogopherjs:go1.20from May 28, 2024
Merged
[go1.20] Updating generics overrides for crypto#1312nevkontakte merged 1 commit intogopherjs:go1.20from
nevkontakte merged 1 commit intogopherjs:go1.20from
Conversation
nevkontakte
approved these changes
May 28, 2024
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was holding off on these changes until I could figure out what was wrong with a large part of crypto (turns out the issue was in
uintand unrelated to the native overrides for crypto). Since that is now merged, here is the updates to the generics native overrides for crypto.In go1.20 crypto the curves were broken up into nearly identical parts. Our original go1.19 overrides could be reused for most of these changes with minor rework, so that's what I did. I imported the shared override implementation each place the curve was needed.
This also includes an update to the cache removal. These are not generics related, we just can't handle the garbage collect hooks for the crypto cache, so we just make it always a cache miss.
CI will still fail for go1.20. We're missing an unrelated method (I'm working on it as part of another PR), but once that's in the build passes. Then this will remove most, but not all, of the problems in crypto. There is still a buffer overflow issue that I haven't looked into yet but felt unrelated to the curves.
This is part of #1270