Move function translation code into a separate file.#1318
Merged
nevkontakte merged 1 commit intogopherjs:masterfrom Jun 30, 2024
Merged
Move function translation code into a separate file.#1318nevkontakte merged 1 commit intogopherjs:masterfrom
nevkontakte merged 1 commit intogopherjs:masterfrom
Conversation
The logic is already very complicated and breaking it up into more manageable methods will improve readability. - Broke out nestedFunctionContext() and translateStandaloneFunction() - Removed the need to return function param names from translateFunctionBody() (based on commit 2e9a5ce)
flimzy
approved these changes
Jun 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic is already very complicated and breaking it up into more manageable methods will improve readability.
(based on commit 2e9a5ce)