[go1.20] Removing some uses of unsafeheader.Slice from reflect#1321
Merged
flimzy merged 1 commit intogopherjs:go1.20from Jul 13, 2024
Merged
[go1.20] Removing some uses of unsafeheader.Slice from reflect#1321flimzy merged 1 commit intogopherjs:go1.20from
unsafeheader.Slice from reflect#1321flimzy merged 1 commit intogopherjs:go1.20from
Conversation
flimzy
approved these changes
Jul 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrode the following to not use
unsafeheader.Slicesince GopherJS implemented slices differently:Value. SetZeroValue.UnsafePointerValue.extendSliceused byreflect.Appendandreflect.AppendSliceThe last use of
unsafeheader.Sliceis incvtSliceArrayused by methods like Value.Convert. I will put that update into another PR.The CI will still not pass yet, but this will fix the tests like
TestIsZeroandTestAppendso they pass.This is part of #1270