[go1.20] Fixing a encoding/gob override#1323
Merged
flimzy merged 1 commit intogopherjs:go1.20from Jul 16, 2024
Merged
Conversation
flimzy
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I started working on go1.20 I added an override to encoding/gob
growSliceto replace it's usage of generics. Once I got the transpile to work other issues popped up that hid a mistake. Those other issues are now taking care of so this issue came back up. I fixed the mistake and skipped some tests checking mallocs. Additionally, I checkedTestEndToEndoverride since it has an old TODO on it. It appears the issue with the Marr field still exist so I left it alone.The experimental generics can handle encoding/god without the override to
growSlicenow. The unit-tests pass in the same amount of time (within some variance). However, until generics is ready to get out of experimental mode, the overrides for generics are left in. Even after release of generics, this doesn't affect any exported code so can be cleaned up later.CI will still not pass after this change. However, encoding/gob's unit-tests should pass.
This is part of #1270