[go1.20] Adding skips to some crypto tests#1325
Merged
flimzy merged 1 commit intogopherjs:go1.20from Jul 19, 2024
Merged
Conversation
flimzy
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a crypto/tls test, TestCertCache, and a benchmark, BenchmarkCertCache, that were locking up CI. Those tests do testing of Caching with the GC. I skipped both.
CI will still not pass (we're getting close), but now the
GopherJS Test (crypto)job (once the GHA is merged into go1.20) will stop locking up.Part of #1270