[go1.20] Adding experimental generics flag to measure-size.yml for go1.20#1331
Merged
flimzy merged 1 commit intogopherjs:go1.20from Jul 23, 2024
Merged
[go1.20] Adding experimental generics flag to measure-size.yml for go1.20#1331flimzy merged 1 commit intogopherjs:go1.20from
flimzy merged 1 commit intogopherjs:go1.20from
Conversation
nevkontakte
approved these changes
Jul 23, 2024
flimzy
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was bumping the Go version in CI to 1.20.14, I forgot to also include
GOPHERJS_EXPERIMENT: genericsinmeasure-size.yml. Without generics enabled for go1.20, the type check in atomic causes GopherJS to fail the build that is being measured.This change should get
measure-size.ymlCI to pass for go1.20 branch. (The go1.20 branch doesn't have the CI improvements from master yet so they will take some time to run.)This is part of #1270