Updating Decl's FullNames #1350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
406458e to
6b7259d
Compare
af5c6ae to
65c5c0b
Compare
flimzy
reviewed
Dec 12, 2024
nevkontakte
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blocking analysis was looking up the generic name for a declaration and may have been finding the function variable declaration (used for storing all instances of a generic function). To fix this we need the declarations to have better full names.
Changes:
I added some methods used to generate names that could be used to lookup decls in most cases. In some cases it would be difficult to get a unique name, e.g.
initfunctions, when performing a lookup in anArchive. Fortunately, those cases have no need to be looked up (yet or ever as far as I can figure).Updated the unit-tests that were using regular expression matching of the JS code to instead use these new names.
Added
t.Helper()calls intoinfo_test.goassert methods, as asked for in Fixing issues in analysis around generics #1351 (comment)This is related to #1013 and #1270