Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DCE update to support nested types #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Conversation

grantnelson-wf
Copy link
Collaborator

@grantnelson-wf grantnelson-wf commented Jun 5, 2025

WAIT

This is a follow up to #1374, so wait until that is merged to master prior to reviewing this PR.
Or only look at the DCE commit's changes.

Summary

Updated DCE to support nested types. See "Fixing DCE" in summary of #1370.
The update will make it so that types nested inside of a function or method are only marked as alive when the function or method is marked as alive.

I also fixed the issue in FindNestingFunc around nested types inside of methods. See the note at the end of the summary for #1370

This is related to #1013 and #1270

@grantnelson-wf grantnelson-wf self-assigned this Jun 5, 2025
@grantnelson-wf grantnelson-wf marked this pull request as ready for review June 5, 2025 17:41
@grantnelson-wf grantnelson-wf merged commit 120c98d into gopherjs:master Jun 16, 2025
10 checks passed
@grantnelson-wf grantnelson-wf deleted the dceUpdate branch June 16, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants