Update to align with policies #1389
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GopherJS is such a long lived project that there are many places that don't follow modern Go policies, therefore we've been fairly relaxed about policies overall. They are more what you call "guidelines" than actual rules.
This PR is simply to correct some of the code that doesn't align with Go's recommendations, such as found in Effective Go. This PR contains:
interface{}
toany
incjs
that should have been part of that packagejsfile.JSFile
=>incjs.File
There are probably a lot more fixes that I could do, but I didn't want this PR to get too long so I kept to the most noticeable issues (i.e. issues that stuck out first to me).