Worked on gopherjs serve#1394
Merged
grantnelson-wf merged 2 commits intogopherjs:masterfrom Nov 4, 2025
Merged
Conversation
nevkontakte
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was working on the sourcemap and playground, I found that sometimes gopherjs serve couldn't find a file to serve.
For example, serving from
github.com/[...]/gopherjs.github.io/playground/would fail to find theinternal/playgroundpackage (that package is in some of the ideas I've had for the playground). The requested file wasgithub.com/[...]/gopherjs.github.io/playground/internal/playground. That file was not able to be found. I added another basic import call but would getno required module provides package [...]; to add it: go get [...]. So I added some other ways to quickly look up files without using import.I also:
--log_level debugsourcemapx.Filterthat can be used with the playgroundsubstr, that is deprecated, withsubstring. They are not one-to-one (see thesubstringlink for details), but since we mostly use it to trim the start, with one exception that starts at 0, the difference betweensubstr(start, length)andsubstring(start, end)looks like a drop in replacement for our code