Merged
Conversation
flimzy
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made three changes:
Removed the unneeded
GOPHERJS_EXPERIMENTfrom a CI workflowRemoved a comment about checking if the
xorLoopmethod should still be removed now that generics has been implemented. Yes, it should be because it is usinguintptrand we'd need it to beuintif we were to use it. That's just as much work as purging it so we'll just remove the comment and continue to purge the functionUpdated
chainedCtx.Importto return the primaryImporterror if both fail since the secondaryImporterror will say that "$GOPATH not set." which can be confusing. This is because the secondaryImportis for the virtual files in the gopherjs context so the context doesn't have GOPATH set in it. This is not specific to go1.20 but me and some other devs at Workiva were trying to help a new dev setup his computer and we kept getting "$GOPATH not set." I wanted to see why when his GOPATH was definitely setup correctly. (The problem ended up being that he was checking out repos into his home directory then symlinking them into the Go path and that was causing other conflicts finding packages.)After these changes (the first two) were the only changes I saw that still needed to be made to the go1.20 branch before I felt it ready. They are based on comments in #1398