Include *.inc.js files consistently #330
Conversation
|
I considered this solution, but I think it breaks architecture too much. |
|
Would you like me to work on that solution? It sounds like you have a pretty good idea of what should happen, so if you have the time to tackle it, no doubt your time spent would be more efficient. But I'm willing to try my hand at it if you want me to, and if it wouldn't actually be a bigger use of your time responding to my changes. |
An alternative proposal to finish fixing #306, in response to comments on #328.
Moving the call to
jsFilesFromDir()intoImport()doesn't work with the current code layout, asImport()doesn't know anything about thegbuild.Packagedata structure, only the official Gobuild.Packagestructure. So I instead moved it toBuildPackage().The only (potential) drawback to this, is that it means we include
*.inc.jsfiles completely consistently for all call methods. The one place where this causes a change of behavior is when callinggopherjs build <files>. Under the old behavior, executinggopherjs build foo.gowould not include foo.inc.js in the final output. Under the new behavior, it will. If the old behavior is important to preserve*, something more clever needs to be done (which I'm willing to tackle myself, too, if it's deemed important).*The only way I can imagine the old behavior being useful is for testing... someone might want to choose which JS file(s), among many, to include at build time. But I don't know if that was actually the intention, or if this "feature" was unintentional.