Add support for executing examples #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Examples are working, in general. But there is still some corner case where GopherJS hangs (see #529). I don't expect this is directly related to Examples, and as such it might be appropriate to merge this before solving #529, but running all upstream examples automatically in CircleCI is not an option before solving #529. But it's probably worth at least investigating #529 more fully before making that call (which I intend to do as time permits). |
|
LGTM, thanks @flimzy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #239. It is a followup to #380, now that #381 is fixed to add support for executing example code along with tests.
I think this is complete, but I want to do some additional testing before declaring it so.