Use defer attribute in gopherjs serve default HTML. #570
Conversation
It specifies that the script is executed when the page has finished parsing.
This affects the default HTML served by gopherjs serve command when there
isn't an index.html provided. Advanced users who want custom behavior will be
specifying their own HTML anyway. For beginners or people looking to write
a quick snippet, having the script be deferred makes it easier to not worry about
the script running before the body is available. It allows writing:
var document = dom.GetWindow().Document().(dom.HTMLDocument)
func main() {
body := document.Body()
// ... use body right away
}
Instead of having to write:
var document = dom.GetWindow().Document().(dom.HTMLDocument)
func main() {
switch readyState := document.ReadyState(); readyState {
case "loading":
document.AddEventListener("DOMContentLoaded", false, func(_ dom.Event) {
go setup()
})
case "interactive", "complete":
setup()
default:
panic(fmt.Errorf("internal error: unexpected document.ReadyState value: %v", readyState))
}
}
func setup() {
body := document.Body()
// ... use body right away
}
Which is more user friendly.
References:
- http://www.w3schools.com/tags/att_script_defer.asp
- https://developer.mozilla.org/en/docs/Web/HTML/Element/script
- http://caniuse.com/#feat=script-defer
|
Hmm. So with vecty I avoided that "body not yet available" situation by setting |
|
From my testing in Chrome 55, doing something like this without func main() {
body := js.Global.Get("document").Call("createElement", "body")
body.Set("innerHTML", "Some body.")
js.Global.Get("document").Set("body", body)
}But adding I'll withdraw this proposal as-is because it has this disadvantage, and think more about it if there's a way to not have it. Even if there's no way to have both, it might still be better for |
|
Closing because I've withdrawn this particular implementation attempt for now, due to the above problem. I've opened #571 to track the issue and continue the discussion in. |
|
Maybe try to add this before the other script tag: |
#860)" This reverts commit bf5fc7d. Reason: Discussion at #570 (comment)
#860)" (#866) This reverts commit bf5fc7d. Reason: Discussion at #570 (comment)
Note, because the implementation was trivial, this PR serves as both a proposal (up for discussion) and implementation in one.
The defer attribute specifies that the script is executed when the page has finished parsing.
This affects the default HTML served by gopherjs serve command when there
isn't an index.html provided. Advanced users who want custom behavior will be
specifying their own HTML anyway. For beginners or people looking to write
a quick snippet, having the script be deferred makes it easier to not worry about
the script running before the body is available. It allows writing:
Instead of having to write:
Which is more user friendly.
References: