Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] compiler: fix handling of struct, array and interface values #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myitcv wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] compiler: fix handling of struct, array and interface values #669

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8d039e
compiler: fix handling of struct, array and interface values.
myitcv Jul 31, 2017
a1b88e1
Fix externalizeFunction to also copyInterfaceVal for returned struct
myitcv Apr 15, 2018
ab58715
Regen prelud_min
myitcv Apr 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix externalizeFunction to also copyInterfaceVal for returned struct 
vals
  • Loading branch information
@myitcv
myitcv committed Apr 21, 2018
commit a1b88e1e2346d82dec6cc06acbd368aa91b65f39
4 changes: 2 additions & 2 deletions compiler/prelude/jsmapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,10 @@ var $externalizeFunction = function(v, t, passThis) {
case 0:
return;
case 1:
return $externalize(result, t.results[0]);
return $externalize($copyInterfaceVal(result), t.results[0]);
default:
for (var i = 0; i < t.results.length; i++) {
result[i] = $externalize(result[i], t.results[i]);
result[i] = $externalize($copyInterfaceVal(result[i]), t.results[i]);
}
return result;
}
Expand Down