Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Detect unsupported GOOS #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Detect unsupported GOOS #879

merged 1 commit into from
Dec 28, 2021

Conversation

inkeliz
Copy link
Contributor

@inkeliz inkeliz commented Nov 9, 2018

Currently the developer running on Windows should use set GOOS=linux and then run the gopherjs. Have some issues about it: #875, #776.

This changes makes the gopherjs to use the GOOS=linux, clearly telling that the GOOS was changed, the user can still use the GOOS=darwin or GOOS=linux manually.

The README says:

gopherjs uses your platform's default GOOS value when generating code. Supported GOOS values are: linux, darwin. If you're on a different platform (e.g., Windows or FreeBSD), you'll need to set the GOOS environment variable to a supported value. For example, GOOS=linux gopherjs build [package].

This change makes the gopherjs use the GOOS=linux by default on any unsupported GOOS and plataform. If the user are using darwin it will still darwin, even if it's not set on GOOS explicit.


I only test with the gopherjs build, maybe more test should be done.

Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CC @dmitshur

@flimzy flimzy merged commit 0f5af05 into gopherjs:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants