Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: use black list instead of white list for standard library tests #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2019
Merged

ci: use black list instead of white list for standard library tests #902

merged 1 commit into from
Mar 9, 2019

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Mar 9, 2019

Using a black list is a more effective mechanism for expressing those
standard library packages we don't want to test because it means we
don't need to manually check whether new standard library packages have
been added that would otherwise need to be added to the white list.

See the discussion in #900 for
more context.

@myitcv
ci: use black list instead of white list for standard library tests
380946f 
Using a black list is a more effective mechanism for expressing those
standard library packages we don't want to test because it means we
don't need to manually check whether new standard library packages have
been added that would otherwise need to be added to the white list.

See the discussion in gopherjs#900 for
more context.
@myitcv myitcv requested a review from hajimehoshi March 9, 2019 14:46
hajimehoshi
hajimehoshi approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hajimehoshi hajimehoshi merged commit a7e14a8 into gopherjs:master Mar 9, 2019
@dmitshur
Copy link
Member

dmitshur commented Sep 15, 2019 •
edited
Loading

grep -v -x -f .std_test_pkg_exclusions is behaving differently on macOS compared to Linux. :(

On Linux (working as expected):

$ grep --version
grep (GNU grep) 2.25
[...]
$ echo -e "fmt\nruntime\nruntime/cgo" | grep -v -x -f .std_test_pkg_exclusions
fmt

On macOS (not filtering out runtime/cgo):

$ grep --version
grep (BSD grep) 2.5.1-FreeBSD
$ echo -e "fmt\nruntime\nruntime/cgo" | grep -v -x -f .std_test_pkg_exclusions
fmt
runtime/cgo

Edit: It might be a bug in BSD grep. 🤦‍♂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajimehoshi hajimehoshi hajimehoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myitcv @dmitshur @hajimehoshi