Add SymfonyHttpClient file configuration#177
Merged
Merged
Conversation
Contributor
Author
|
Maybe bringing a private method like |
gordalina
approved these changes
May 11, 2021
Owner
|
Thank you for your contribution! Released in |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, current implementation does not allow to use
SymfonyHttpClientin the config file.This PR decouples the
httpobject creation logic from the config parsing.However, there's still some inconsistencies because
Configobject properties and cli/file parameters are being merged/mixed up/not consistently named (temp_dir/webAllowInsecure).