Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mehmetoguzderin
Copy link
Member

This PR synchronizes WGSL-related portions of the CG charter with the upcoming (to-be-merged) WG charter. One important difference is the mention of grammar-checking facilities. @dneto0 @alan-baker WDYT?

Thank you!

@mehmetoguzderin
Copy link
Member Author

cg-charter.html Outdated
<p>
The Community Group will develop a continuous integration mechanism to validate the
grammar of WebGPU Shading Language against syntactic ambiguities and potential
mechanical issues with primary reliance on an industry-adopted tool that can report
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to read "with primary reliance on an industry-adopted tool". That seems to leave the door open to a mechanism based on a closed-source and commercial tool, provided it is widely adopted by the industry. Is that intended? Or is the goal rather to build on top of an open-source and free-to-use tool so that the community can leverage this work more easily?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tidoust Exactly, I am sorry for wording there. Would explicitly mentioning open-source and such aim help?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tidoust I've tried to rephrase a bit

cg-charter.html Outdated
Comment on lines 189 to 192
<dd>A Shading Language specification that defines the programmable
interface to the GPU for the Web graphics and computation
pipeline, and that can be translated or compiled into
platform-specific instructions.</dd>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A possible addition might be similar to the API side we make an explicit point about representability in the shading languages of modern APIs. This currently could be read as WGSL will be compiled directly to machine code, but I might be trying to view it too naively for the purpose of reviewing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-baker The actual WG charter might be a better place for the feedback- I am just reflecting that in this case! thank you cc: @tidoust

@mehmetoguzderin
Copy link
Member Author

Sync'd with the upstream WG charter. thanks @alan-baker for moving it there

Copy link

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link

@kdashg kdashg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't see any problems with this at this stage.

@kdashg kdashg merged commit 565faca into gpuweb:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants