Add spec for texture creation #1658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds validation rules for texture creation. It is based on: - PR 799 (gpuweb#799) from Myles, and the comments. - Issue 1522 (gpuweb#1522) I investigated when I was implementing 3D textures on Dawn project, and the comments.
|
FYI, @bbernhar and @RafaelCintron |
kainino0x
reviewed
Apr 27, 2021
|
Also sorry for the delay in reviewing! |
Co-authored-by: Kai Ninomiya <[email protected]>
Co-authored-by: Kai Ninomiya <[email protected]>
kainino0x
approved these changes
Apr 27, 2021
kainino0x
reviewed
Apr 27, 2021
Co-authored-by: Kai Ninomiya <[email protected]>
kvark
approved these changes
Apr 28, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds validation rules for texture creation. It is based on:
and the comments.
investigated when I was implementing 3D textures on Dawn project,
and the comments.
Preview | Diff