Remove GPUSamplerDescriptor.maxAnisotropy. #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We agreed that anisotropic filtering would be an extension so this parameters shouldn't be defined in the descriptor for core WebGPU.
|
@Kangz could you link to the minutes/discussion/investigation on where we agreed to this, please? |
|
Mmmmh it seems recent-ish versions of Samsung's ARM driver don't support it, including the 9S and 8S. Supporting it unconditionally would prevent WebGPU from running on these devices. We (Google) should probably ask ARM about it. |
|
Discussed at 25 March teleconference |
kdashg
approved these changes
Mar 25, 2019
This was referenced Dec 2, 2020
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
(originally gpuweb#202 against glsl-dependent) The test originally checked for the validation error on the wrong device. Co-authored-by: Austin Eng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We agreed that anisotropic filtering would be an extension so this
parameters shouldn't be defined in the descriptor for core WebGPU.