Provide texture and vertex format types #206

grorg · 2019-02-07T22:33:43Z

Closes #164.

Closes gpuweb#164.

grorg · 2019-02-07T22:34:23Z

Notes:

includes -srgb versions
does not include extended range formats
does not include 16 bit packed since they are not available on all platforms
same with 32 bit packed (although maybe they should be there)

litherum · 2019-02-07T22:55:52Z

grorg · 2019-02-07T23:12:37Z

One format that seems to be supported "everywhere" is r10g10b10a2.

Should that be added? I guess so.

Kangz · 2019-02-08T09:31:02Z

Thanks for contributing this! The naming convention looks great. We don't need to investigate portability of formats just yet be we could include RGB10A2 and RGB565 just as examples of how packed formats are named.

Also could the texture naming convention comment show how compressed formats would be named?

kvark

Thank you!
Looks good for the most part, noted a few suggestions

kvark · 2019-02-08T16:38:03Z

design/sketch.webidl

-    "d32-float-s8-uint"
-    // TODO other formats
+    /* Normal 8 bit formats */
+    "a8unorm",


note: this one isn't supported by Vulkan

In theory it is if you use component swizzling in the image view

Yes, for this particular case we could emulate the format. This is only possible since A8 behaves like R8 for all scenarios where an image view is not involved.

I think we should remove it. Sorry I didn't notice this before.

We can always add it back later if we think it's worth it.

kvark · 2019-02-08T16:41:04Z

design/sketch.webidl

-    "r8g8b8a8-unorm",
-    "r8g8b8a8-uint",
-    "b8g8r8a8-unorm",
-    "d32-float-s8-uint"


would be good to have some depth (+-stencil) formats as well

kvark · 2019-02-08T16:43:22Z

design/sketch.webidl

+    "char2",
+    "char3",
+    "char4",
+    "ucharnorm",


merging words together here doesn't look particularly good
maybe we can have uchar1norm instead?

Bikeshedding, but I don't like how the "u" and "norm" are separated either.

the "norm" used in vertex formats doesn't even match the texture format conventions, where only "unorm" and "snorm" are allowed. OTOH, I don't feel like bikeshedding too much...

(same with "int" "short" "char" - above they would be "sint" "sshort" "schar", which are names I definitely don't love. Plus "int" especially has a long history of having variable size....)

magcius · 2019-02-08T17:05:00Z

design/sketch.webidl

+    /* Normal 128 bit formats */
+    "rgba32uint",
+    "rgba32sint",
+    "rgba32float",


Are there no BGRA, ARGB, or ABGR texture types? Are these actually RGBA32 (in that they are one 32-bit word which is host-endianness-specific?), or are they R8G8B8A8? Does it matter since POWER is basically dead anyway?

* Provide texture and vertex format types Closes gpuweb#164.

Kangz · 2019-02-11T10:38:20Z

This was still missing depth stencil formats but we can infer the naming conventions from what is there.

* Provide texture and vertex format types Closes gpuweb#164.

jespertheend · 2020-12-09T20:47:24Z

Is there a reason for using char, short and half? Maybe I'm misunderstanding what these formats represent, but using a similar format to TypedArrays such as uint8, uint16, float16 and float32 seems more logical to me.

edit: hmm now that I think about it, that would result in something like uint82 for a 2 component type, which is probably not ideal. Though I'm still a bit confused by what char and short mean exactly. The current spec for int says signed 32-bit integer value whereas for char it says signed 8-bit value. Does this mean it is also an integer?

kainino0x · 2020-12-09T21:23:18Z

I think that's exactly it, we didn't come up with a clearer way of expressing e.g. vec2<uint16>. But we probably could, if we really don't like char/short. We agreed on those because the meaning is fairly clear even though they don't match a whole lot else.

IIRC some API(s) merge vertex and texture formats so end up with things like rg16uint/rg16unorm vertex formats. We chose to specify the number of components for vertex formats, but the rgba components for texture formats. That also isn't entirely necessary. rg16uint/rg16unorm or 2x16uint/2x16unorm or uint16x2/unorm16x2 could work.

Does this mean it is also an integer?

yes, they're supposed to be integers if they don't say "norm". Reason it's worded that way is there are also the normalized versions which don't represent integers.

I also noticed we have this bit of text that seems to be obsolete:

If no number of values is given in the name, a single value is provided. If the format has the -bgra suffix, it means the values are arranged as blue, green, red and alpha values.

as there are no vertex formats with bgra.

kainino0x · 2020-12-09T21:24:28Z

fwiw I think the main reason we ended up with the current naming is it's similar to what Metal uses.

jespertheend · 2020-12-09T21:35:55Z

Oh I like uint16x2. Maybe it's because I haven't worked with low level programming languages a whole lot. But I was a bit confused by the names and had to go over what each of them meant in my head. I think specifying the bits in the name would help with that.

Reason it's worded that way is there are also the normalized versions which don't represent integers

Ah that makes sense. I suppose there is no normalized version for 32 bit integers because of hardware limits? Or is this list incomplete?

I also noticed we have this bit of text that seems to be obsolete

Ah cool, I was wondering about that.

kainino0x · 2020-12-09T21:46:28Z

I suppose there is no normalized version for 32 bit integers because of hardware limits?

I believe that's the reason, yeah.

kainino0x · 2020-12-21T22:32:38Z

editors resolution: open a PR to rename these to match texture formats, including the rgba part.
Rationale: while textures are often colors and vertex data is often not, the rgba naming corresponds with the .rgba swizzling of the vec datatypes as fed into the shaders. And it's just more consistent.

I'll also fix that obsolete text above.

See recent discussion on gpuweb#206

* Rename GPUVertexFormat members to match GPUTextureFormat See recent discussion on #206 * try out some new names, not sold on them * less is more * Remove stale line * I deleted the wrong thing... * update bikeshed to try to fix build? * upgrade better * try --skip-manifest * add a dry run with line numbers for errors * temporarily enable (buggy) --line-numbers * undo * fix merge

Provide texture and vertex format types

e595110

Closes gpuweb#164.

grorg requested a review from Kangz February 7, 2019 22:34

kvark approved these changes Feb 8, 2019

View reviewed changes

magcius reviewed Feb 8, 2019

View reviewed changes

grorg added 3 commits February 10, 2019 07:27

Add compressed texture naming

b7ce6a2

Add packed examples - one 16bit, two 32bit

d7f854c

Remove a8unorm - not supported directly on vulkan

c51fe82

grorg merged commit bce24a2 into gpuweb:master Feb 9, 2019

grorg deleted the vertex-texture-formats branch February 9, 2019 20:35

JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Feb 10, 2019

Provide texture and vertex format types (gpuweb#206)

ea57e69

* Provide texture and vertex format types Closes gpuweb#164.

JusSn mentioned this pull request Feb 19, 2019

Add depth/stencil GPUTextureFormats #211

Merged

kvark mentioned this pull request Feb 28, 2019

Clarify the semantics of packed formats #224

Open

JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Mar 26, 2019

Provide texture and vertex format types (gpuweb#206)

1e9914a

* Provide texture and vertex format types Closes gpuweb#164.

kainino0x added the for webgpu editors meeting label Dec 9, 2020

kainino0x removed the for webgpu editors meeting label Dec 21, 2020

kainino0x added a commit to kainino0x/gpuweb that referenced this pull request Dec 21, 2020

Rename GPUVertexFormat members to match GPUTextureFormat

036e104

See recent discussion on gpuweb#206

kainino0x added a commit to kainino0x/gpuweb that referenced this pull request Dec 21, 2020

Rename GPUVertexFormat members to match GPUTextureFormat

2da2861

See recent discussion on gpuweb#206

kainino0x mentioned this pull request Dec 21, 2020

Rename GPUVertexFormat members to match GPUTextureFormat #1322

Merged

kainino0x mentioned this pull request Aug 18, 2023

rgb10a2 vertex format #4275

Closed

Provide texture and vertex format types #206

Provide texture and vertex format types #206

Uh oh!

Conversation

grorg commented Feb 7, 2019

Uh oh!

grorg commented Feb 7, 2019

Uh oh!

litherum commented Feb 7, 2019

Uh oh!

grorg commented Feb 7, 2019

Uh oh!

Kangz commented Feb 8, 2019

Uh oh!

kvark left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magcius Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magcius Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kangz commented Feb 11, 2019

Uh oh!

jespertheend commented Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kainino0x commented Dec 9, 2020

Uh oh!

kainino0x commented Dec 9, 2020

Uh oh!

jespertheend commented Dec 9, 2020

Uh oh!

kainino0x commented Dec 9, 2020

Uh oh!

kainino0x commented Dec 21, 2020

Uh oh!

Uh oh!

magcius Feb 8, 2019 •

edited

Loading

magcius Feb 8, 2019 •

edited

Loading

jespertheend commented Dec 9, 2020 •

edited

Loading