Remove no-op minBindingSize text #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minBindingSize is never undefined (it defaults to 0), so this "if" wasn't doing anything.
|
We had this discussion previously about whether to allow "0" default, or have an explicit signal that the value is not provided. |
|
I'm not sure how explicitly we made that decision, but that's what's already in the spec because minBindingSize defaults to 0 in the IDL. So regardless, in the current state of the spec, this is a no-op. |
kvark
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minBindingSize is never undefined (it defaults to 0), so this "if"
wasn't doing anything.
Preview | Diff