-
Notifications
You must be signed in to change notification settings - Fork 335
Raise maxUniformBufferBindingSize to 64k #2159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This loses support for exactly 0 gpuinfo.org reports that were still supported with our other requirements.
Are we sure this won't run into limits on D3D12 and Metal? |
|
I thought this wasn't an issue from the conclusion here: ... but I guess that was a wrong conclusion? (If so the error message is kind of misleading.) |
Just tried 4096 elements of vec4, and it seems to pass FXC. |
Actually, if this stackoverflow answer is correct: https://stackoverflow.com/a/18260016 |
Double-checked that we can create more than 4K "elements" in a constant buffer - http://shader-playground.timjones.io/09fe5a6eabe2ada04525de0f67f2159f |
FXC doesn't seem sufficient to check this though. For example if I add one more field to that struct (so it goes over 64k) it still doesn't complain. |
@RafaelCintron can you provide input from the D3D12 side? |
Yes, this should work from the D3D12 side. |
[Editors] |
(Old metal feature set tables show "Maximum buffer length" as no less than 256MB. Now it's queried dynamically: https://developer.apple.com/documentation/metal/mtldevice/2966563-maxbufferlength) |
SHA: 9a87331 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 9a87331 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 9a87331 Reason: push, by @kainino0x Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was upped in gpuweb/gpuweb#2159 Bug: dawn:1173 Change-Id: I98d46b9b5a339280d21ddcb2ab039ce7ebce4ec3 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71608 Commit-Queue: Brandon Jones <[email protected]> Auto-Submit: Corentin Wallez <[email protected]> Reviewed-by: Brandon Jones <[email protected]>
This reverts commit 1a57ee9. Reason for revert: Swiftshader does not support 2^16 at the moment, and this is causing all Swiftshader tests to be skipped silently. Original change's description: > Bump maxUniformBindingSize to 2^16 from 2^14 > > This was upped in gpuweb/gpuweb#2159 > > Bug: dawn:1173 > Change-Id: I98d46b9b5a339280d21ddcb2ab039ce7ebce4ec3 > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71608 > Commit-Queue: Brandon Jones <[email protected]> > Auto-Submit: Corentin Wallez <[email protected]> > Reviewed-by: Brandon Jones <[email protected]> [email protected],[email protected],[email protected],[email protected],[email protected] Change-Id: Ib7d6023adac3f99b8e7238035eed2a16f2ced6d0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:1173 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/71840 Reviewed-by: Austin Eng <[email protected]> Commit-Queue: Loko Kung <[email protected]>
This loses support for exactly 0 gpuinfo.org reports that were still
supported with our other requirements.
Preview | Diff