Describe tight-packing of image-copy ops, including depth/stencil #2331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6582137 to
6fd03f7
Compare
6fd03f7 to
0b22936
Compare
Kangz
approved these changes
Nov 22, 2021
kvark
reviewed
Nov 23, 2021
spec/index.bs
Outdated
| WebGPU provides {{GPUCommandEncoder/copyBufferToTexture()}} for buffer-to-texture copies and | ||
| {{GPUCommandEncoder/copyTextureToBuffer()}} for texture-to-buffer copies. | ||
|
|
||
| Pixels are tightly-packed in the linear-memory layout of each row of an image copy. |
There was a problem hiding this comment.
Maybe worth explaining what this is, then adding a note saying "this is often referred to as linear memory layout"?
I.e. say that texel (i+1, j) follows (i, j), and row (, j+1) follows row (, j).
There was a problem hiding this comment.
I tried to sidestep this by only explaining the layout of each individual row, not the whole image, but we do need this somewhere eventually. GPUImageDataLayout has TODOs to describe linear memory layouts.
There was a problem hiding this comment.
Moved this to that section (which makes more sense) and rewrote it in terms of texel blocks.
kvark
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a note on how to read/write depth/stencil formats which are not copyable.
Fixes #652 (
remaining open questions there are being split out to separate issuesdecided not to do that, just added notes in the spec).CC #2328
Preview | Diff