Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow GPUShaderModules to contain MTLLibraries #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2021
Merged

Allow GPUShaderModules to contain MTLLibraries #2363

merged 1 commit into from
Dec 5, 2021

Conversation

litherum
Copy link
Contributor

@litherum litherum commented Nov 30, 2021 •
edited by pr-preview bot
Loading

The resolution is to add a dictionary of entry point name to pipeline layout to createShaderModule(), which is optional, and implementations can totally ignore it 100% (no validation).

Fixes #1064.

Preview | Diff

@litherum litherum force-pushed the GPUShaderModuleCompilationHints branch from 332d695 to 5c565e3 Compare November 30, 2021 22:46
@github-actions
Copy link
Contributor

Previews, as seen when this build job started (5c565e3):
WebGPU | IDL
WGSL
Explainer

kvark
kvark reviewed Dec 2, 2021
View reviewed changes
Copy link
Contributor

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note

kainino0x
kainino0x approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while but this looks like what we agreed on!

kainino0x
kainino0x reviewed Dec 3, 2021
View reviewed changes
@litherum
Allow GPUShaderModules to contain MTLLibraries
28b6c44 
> The resolution is to add a dictionary of entry point name to pipeline layout to createShaderModule(), which is optional, and implementations can totally ignore it 100% (no validation).

Fixes gpuweb#1064.
@litherum litherum force-pushed the GPUShaderModuleCompilationHints branch from 5c565e3 to 28b6c44 Compare December 5, 2021 03:44
@litherum litherum enabled auto-merge (squash) December 5, 2021 03:45
@litherum litherum merged commit 62323a8 into gpuweb:main Dec 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2021

Previews, as seen when this build job started (28b6c44):
WebGPU | IDL
WGSL
Explainer

github-actions bot added a commit that referenced this pull request Dec 5, 2021
@litherum @github-actions
Allow GPUShaderModules to contain MTLLibraries (#2363)
1d801a5 
SHA: 62323a8
Reason: push, by @litherum

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Dec 5, 2021
@litherum @github-actions
Allow GPUShaderModules to contain MTLLibraries (#2363)
2f7dca1 
SHA: 62323a8
Reason: push, by @litherum

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Dec 5, 2021
@litherum @github-actions
Allow GPUShaderModules to contain MTLLibraries (#2363)
bca6ce9 
SHA: 62323a8
Reason: push, by @litherum

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark left review comments

@kainino0x kainino0x kainino0x approved these changes

@Kangz Kangz Awaiting requested review from Kangz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method of ensuring GPUShaderModules can contain MTLLibraries
3 participants
@litherum @kvark @kainino0x