Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Combine section headers which define the same function #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2022
Merged

Combine section headers which define the same function #3020

merged 3 commits into from
Jun 14, 2022

Conversation

dj2
Copy link
Member

@dj2 dj2 commented Jun 8, 2022

This CL recombines sections which define the same builtin with different
arguments (scalar, vector, f32, f16, etc).

@dj2
Combine section headers which define the same function
7c78d50 
This CL recombines sections which define the same builtin with different
arguments (scalar, vector, f32, f16, etc).
@dj2 dj2 added wgsl WebGPU Shading Language Issues copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) labels Jun 8, 2022
@dj2 dj2 requested a review from dneto0 June 8, 2022 17:43
@dj2 dj2 self-assigned this Jun 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Previews, as seen when this build job started (7c78d50):
WebGPU | IDL
WGSL
Explainer

@dj2
Copy link
Member Author

dj2 commented Jun 13, 2022

Ping.

dneto0
dneto0 approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
I filed folllow up #3044 to put overload, parameterization first. I think that's the last readability improvement.

@dneto0 dneto0 merged commit e37fc8f into gpuweb:main Jun 14, 2022
github-actions bot added a commit that referenced this pull request Jun 14, 2022
@dj2 @github-actions
Combine section headers which define the same function (#3020)
278e644 
SHA: e37fc8f
Reason: push, by @dneto0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dj2 dj2 deleted the combine branch June 14, 2022 13:25
github-actions bot added a commit that referenced this pull request Jun 14, 2022
@dj2 @github-actions
Combine section headers which define the same function (#3020)
4e120cd 
SHA: e37fc8f
Reason: push, by @dneto0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jun 14, 2022
@dj2 @github-actions
Combine section headers which define the same function (#3020)
43a60a6 
SHA: e37fc8f
Reason: push, by @dneto0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jdarpinian pushed a commit to jdarpinian/gpuweb that referenced this pull request Aug 12, 2022
@dj2 @jdarpinian
Combine section headers which define the same function (gpuweb#3020)
62f1c43 
* Combine section headers which define the same function

This CL recombines sections which define the same builtin with different
arguments (scalar, vector, f32, f16, etc).

* move description down

* force build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneto0 dneto0 dneto0 approved these changes

Assignees

@dj2 dj2

Labels
copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) wgsl WebGPU Shading Language Issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dj2 @dneto0