Don't throw exception when getBindGroupLayout index > maxBindGroups #3506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be handled by returning an invalid GPUBindGroupLayout instead, as we do if the index is past the end of the actual BGL list (just below in the device timeline validation steps). Since getBindGroupLayout returns a new JS wrapper every time, there's no concern about that behavior in this case. I suspect that's why we had an exception to begin with.
7 tasks
|
Previews, as seen when this build job started (7708294): |
Kangz
approved these changes
Oct 5, 2022
|
Tacit resolution period is not over yet, but landing tentatively so I can keep editing with this landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be handled by returning an invalid GPUBindGroupLayout instead, as we do if the index is past the end of the actual BGL list (just below in the device timeline validation steps).
Since getBindGroupLayout returns a new JS wrapper every time, there's no concern about that behavior in this case. I suspect that's why we had an exception to begin with.
This exception dates back to when we added getBindGroupLayout originally, in #543.