Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use automatic expiry for imported textures, remove .expired #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2023
Merged

Use automatic expiry for imported textures, remove .expired #3633

merged 3 commits into from
Feb 2, 2023

Conversation

kainino0x
Copy link
Contributor

@kainino0x kainino0x commented Nov 24, 2022 •
edited
Loading

Depends on PRs #3632 #3645

Fixes #3324

@kainino0x kainino0x added tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet labels Nov 24, 2022
@kainino0x kainino0x added this to the V1.0 milestone Nov 24, 2022
@github-actions

This comment was marked as outdated.

Sign in to view
@kainino0x kainino0x force-pushed the task-sources-external branch 2 times, most recently from a859fb6 to a9cdf08 Compare November 29, 2022 00:10
@kainino0x kainino0x requested a review from toji November 29, 2022 00:13
toji
toji reviewed Nov 29, 2022
View reviewed changes
@kainino0x kainino0x force-pushed the task-sources-external branch from a9cdf08 to 422aae2 Compare December 30, 2022 02:59
@kainino0x kainino0x marked this pull request as ready for review December 30, 2022 02:59
@kainino0x kainino0x requested a review from kdashg January 30, 2023 23:56
@kdashg kdashg merged commit c7c3816 into gpuweb:main Feb 2, 2023
@kainino0x kainino0x deleted the task-sources-external branch February 2, 2023 00:10
@kainino0x
Copy link
Contributor Author

fyi @shaoboyan

@kainino0x kainino0x removed the tacit resolution candidate Editors may be able to resolve and move to tacit resolution queue label Apr 6, 2023
juj added a commit to juj/wasm_webgpu that referenced this pull request Aug 4, 2023
@juj
IDL: Remove GPUExternalTexture.expired. gpuweb/gpuweb#3633
debc34e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji left review comments

@kdashg kdashg kdashg approved these changes

Assignees
No one assigned
Labels
needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet
Projects
None yet
Milestone
Milestone 0
Development

Successfully merging this pull request may close these issues.

How do we specify the timing of external texture expiration?
3 participants
@kainino0x @toji @kdashg