Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make aliased bindings an error #3981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2023
Merged

Make aliased bindings an error #3981

merged 1 commit into from
Mar 28, 2023

Conversation

kainino0x
Copy link
Contributor

Add note about optimization.

Fixes #1842

@kainino0x
Make aliased bindings an error
850cf72 
Add note about optimization.

Fixes 1842
@kainino0x kainino0x added the copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.) label Mar 17, 2023
@kainino0x kainino0x added this to the V1.0 milestone Mar 17, 2023
@kainino0x kainino0x requested a review from toji March 17, 2023 23:54
@github-actions
Copy link
Contributor

Previews, as seen when this build job started (850cf72):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

toji
toji approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kainino0x kainino0x merged commit 96ec082 into gpuweb:main Mar 28, 2023
@kainino0x kainino0x deleted the aliasing branch March 28, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toji toji toji approved these changes

Assignees
No one assigned
Labels
copyediting Pure editorial stuff (copyediting, *.bs file syntax, etc.)
Projects
None yet
Milestone
Milestone 0
Development

Successfully merging this pull request may close these issues.

Should the API enforce that writable storage buffer bindings don't alias each other?
2 participants
@kainino0x @toji