Description of loop mechanic was inconsistent #4028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and hence wrong)
|
tidoust marked as non substantive for IPR from ash-nazg. |
mehmetoguzderin
approved these changes
Apr 12, 2023
|
Previews, as seen when this build job started (9865c1d): |
dneto0
requested changes
Apr 12, 2023
wgsl/index.bs
Outdated
| The loop body will execute five times. | ||
| Variable `i` will take on values 0, 1, 2, 3, 4, 5, and variable `twice` will take on values 0, 2, 4, 6, 8. | ||
| The loop body will execute six times. | ||
| Variable `i` will take on values 0, 1, 2, 3, 4, 5, and variable `twice` will take on values 0, 2, 4, 6, 8, 10. |
There was a problem hiding this comment.
Yes, the loop body executes 6 times, but "Twice" only ever gets to 8.
The i variable is incremented after "twice" is updated.
There was a problem hiding this comment.
That's right! Which means my correction was in fact also incorrect... But the merged PR looks good!
dneto0
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and hence wrong. I hope(!) my updated and consistent description is correct.