Replace asynchronous .requestAdapterInfo() with synchronous .info #4662

kainino0x · 2024-05-23T01:06:40Z

Iteration on #4550.

Replaces the GPUAdapter method
Promise<GPUAdapterInfo> requestAdapterInfo();
with a synchronous attribute
[SameObject] readonly attribute GPUAdapterInfo info;

Important points:

requestAdapterInfo() is removed. Chromium will deprecate and remove it and attempt to get any sites migrated off of it, so hopefully Firefox/Safari won't have to implement it at all (though the implementation is trivial so they may choose to, for compatibility with outdated sites).
The available info about a given GPUAdapter may no longer change. You can only get new info by getting a new GPUAdapter. (The only reason this should happen is if someone adds a permission prompt for fingerprintability.)

Less important points:

You can now only get one GPUAdapterInfo object per GPUAdapter object, since adapter.info returns the same object every time you access it.

Fixes #4536

- Add a `[SameObject] readonly attribute GPUAdapterInfo info;` to `GPUAdapter`. - It returns the same JS object every time you access it. - `requestAdapterInfo` still returns a new one each time for minor backward-compatibility reasons. - **HOWEVER** it has been changed to always return an already-resolved promise instead of resolving later. - If the info available to the page changes for some reason (generally shouldn't), the attributes on the `GPUAdapterInfo` object start returning different values (like an empty string gets changed to a non-empty string). Fixes 4536

kainino0x · 2024-05-23T01:11:26Z

Whoops, accidentally opened the PR before I finished it. Should be ready now.

toji

This reflects the decision made on today's call, so LGTM. I have one verbiage nit:

"Info" is an informal abbreviation, which is common to see in code but in the spec prose we should probably spell it out as "information". I do thing that using "adapter info" when talking about the returned object is a reasonable exception, since it directly reflects the name of the returned object.

spec/index.bs

mwyrzykowski · 2024-05-29T22:01:53Z

Looks like this broke or will break https://chat.webllm.ai/, I will mention it to Tianqi Chen who filed another report against WebKit on this

kainino0x · 2024-05-31T05:43:28Z

Chrome is adding a metric to measure usage of requestAdapterInfo() in the wild in preparation for removal.
https://chromium-review.googlesource.com/c/chromium/src/+/5569741
Currently we won't be capturing which websites use it, but we are likely to need to do that so we can reach out to developers to update their sites (once .info has reached Chrome Stable and ideally Safari TP / Firefox Nightly, so they can switch)

mwyrzykowski · 2024-05-31T05:52:51Z

That's great, thank you for adding the metrics. .info should appear in the next or next after next Safari Technology Preview, I merged the change yesterday, but kept requestAdapterInfo to avoid breaking webllm.ai amongst others

beaufortfrancois · 2024-05-31T07:02:44Z

FYI I'm updating Apache TVM used by WebLLM to use adapter.info in apache/tvm#17051.

beaufortfrancois · 2024-06-03T14:46:00Z

FYI https://chat.webllm.ai/ now uses the GPUAdapter info attribute when available following apache/tvm#17051

beaufortfrancois · 2024-06-04T07:58:35Z

The GPUAdapter info attribute is now available in Chrome 127.0.6519.0 (Canary 🐤 at the time of writing). See https://chromiumdash.appspot.com/commit/9e908a7dca56215132ec7afc8962b18f993bbd2d

…hronous GPUAdapter.info field. (gpuweb/gpuweb#4662)

WebGPU is deprecating async adapter.requestAdapterInfo, and replacing it with sync adapter.info. Spec change: gpuweb/gpuweb#4662

… with synchronous .info Closes denoland#24779 Ref gpuweb/gpuweb#4662

…ync .info (#24783) Closes #24779 Ref gpuweb/gpuweb#4662

beaufortfrancois · 2024-09-09T15:47:39Z

@mwyrzykowski Can you affirm that WebGPU will ship in Safari without requestAdapterInfo() method as we're discussing in https://groups.google.com/a/chromium.org/g/blink-dev/c/HxOgGf4NzQ4? I'm happy to file a standards position for that as well

mwyrzykowski · 2024-09-09T17:27:57Z

@mwyrzykowski Can you affirm that WebGPU will ship in Safari without requestAdapterInfo() method as we're discussing in https://groups.google.com/a/chromium.org/g/blink-dev/c/HxOgGf4NzQ4? I'm happy to file a standards position for that as well

We don’t need a standards position but we do implement GPUAdapter.info

Let me check on the status of removing requestAdapterInfo. I don’t think anyone is still depending on that one. It’s not in the specification either, so it would be a website issue if they continue to use it.

mwyrzykowski · 2024-09-09T20:04:36Z

@beaufortfrancois I made the PR to remove it in WebKit now that WebLLM has updated their site - WebKit/WebKit#33333 - in any case we don't intend to support it and would consider it a website issue for using requestAdapterInfo.

beaufortfrancois · 2024-09-10T06:55:54Z

Thank you @mwyrzykowski for your responsiveness!

Spec PR: gpuweb/gpuweb#4662 Intent to deprecate: https://groups.google.com/a/chromium.org/g/blink-dev/c/HxOgGf4NzQ4 Bug: 335383516 Change-Id: Ie396d3d462d07b77aaeb1ffeaca008c701478e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5578020 Reviewed-by: Corentin Wallez <[email protected]> Reviewed-by: Ari Chivukula <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1354048}

This CL removes the GPUAdapter requestAdapterInfo() method by turning off the DeprecatedRequestAdapterInfo blink runtime feature. Once it's stable enough, we'll clean it up entirely. Spec PR: gpuweb/gpuweb#4662 Intent to deprecate: https://groups.google.com/a/chromium.org/g/blink-dev/c/HxOgGf4NzQ4 Bug: 335383516 Change-Id: Ib6b85a9c8d3661992072028e25ba35798e7e6e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569679 Commit-Queue: Fr <[email protected]> Reviewed-by: Richard (Torne) Coles <[email protected]> Reviewed-by: Yoav Weiss (@Shopify) <[email protected]> Cr-Commit-Position: refs/heads/main@{#1364867}

This CL removes entirely the GPUAdapter requestAdapterInfo() method. Spec PR: gpuweb/gpuweb#4662 Intent to deprecate: https://groups.google.com/a/chromium.org/g/blink-dev/c/HxOgGf4NzQ4 Bug: 335383516 Change-Id: I538d083699d52355336e08fdf85d0f1870efa65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5853988 Commit-Queue: Fr <[email protected]> Reviewed-by: Alexei Svitkine <[email protected]> Reviewed-by: Corentin Wallez <[email protected]> Reviewed-by: Yoav Weiss (@Shopify) <[email protected]> Cr-Commit-Position: refs/heads/main@{#1386121}

WebGPU is deprecating async adapter.requestAdapterInfo, and replacing it with sync adapter.info. Spec change: gpuweb/gpuweb#4662

kainino0x added 4 commits March 27, 2024 13:36

Make adapter info immutable

6688ea7

more notes

2457887

remove requestAdapterInfo

460c74e

kainino0x changed the title ~~Sync info~~ Replace .requestAdapterInfo() with .info May 23, 2024

kainino0x changed the title ~~Replace .requestAdapterInfo() with .info~~ Replace asynchronous .requestAdapterInfo() with synchronous .info May 23, 2024

add back algorithm

2d0b20d

kainino0x requested review from jimblandy, toji and mwyrzykowski May 23, 2024 01:11

kainino0x added this to the Milestone 1 milestone May 23, 2024

kainino0x added the api WebGPU API label May 23, 2024

prose for sameobject

e33383e

toji approved these changes May 23, 2024

View reviewed changes

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

spec/index.bs Outdated Show resolved Hide resolved

address comments

2bfd1bc

mwyrzykowski approved these changes May 23, 2024

View reviewed changes

beaufortfrancois mentioned this pull request May 27, 2024

Replace GPUAdapter requestAdapterInfo() method with info attribute gpuweb/cts#3679

Merged

8 tasks

kainino0x merged commit 19516f6 into gpuweb:main May 28, 2024

kainino0x deleted the sync-info branch May 28, 2024 21:13

beaufortfrancois mentioned this pull request May 29, 2024

Use synchronous GPUAdapter.info when available webgpu/webgpureport.org#16

Merged

beaufortfrancois mentioned this pull request May 31, 2024

Use adapter.info when available instead of requestAdapterInfo apache/tvm#17051

Merged

juj added a commit to juj/wasm_webgpu that referenced this pull request Jun 8, 2024

IDL: Remove old WGPUAdapter.requestAdapterInfo() in favor of new sync…

53ee795

…hronous GPUAdapter.info field. (gpuweb/gpuweb#4662)

gyagp pushed a commit to gyagp/onnxruntime that referenced this pull request Jun 17, 2024

[js/webgpu] Prefer adapter.info to adapter.requestAdapterInfo

7d566b4

WebGPU is deprecating async adapter.requestAdapterInfo, and replacing it with sync adapter.info. Spec change: gpuweb/gpuweb#4662

gyagp mentioned this pull request Jun 17, 2024

[js/webgpu] Prefer adapter.info to adapter.requestAdapterInfo microsoft/onnxruntime#21065

Merged

gyagp pushed a commit to gyagp/onnxruntime that referenced this pull request Jun 18, 2024

[js/webgpu] Prefer adapter.info to adapter.requestAdapterInfo

2a70ffd

WebGPU is deprecating async adapter.requestAdapterInfo, and replacing it with sync adapter.info. Spec change: gpuweb/gpuweb#4662

kainino0x added the potentially breaking Could require a breaking change to the API label Jul 15, 2024

petamoriken mentioned this pull request Jul 29, 2024

WebGPU: Replace asynchronous .requestAdapterInfo() with synchronous .info denoland/deno#24779

Closed

littledivy added a commit to littledivy/deno that referenced this pull request Jul 29, 2024

BREAKING(unstable/webgpu): Replace asynchronous .requestAdapterInfo()…

e85caf2

… with synchronous .info Closes denoland#24779 Ref gpuweb/gpuweb#4662

littledivy mentioned this pull request Jul 29, 2024

BREAKING(webgpu/unstable): Replace async .requestAdapterInfo() with sync .info denoland/deno#24783

Merged

littledivy added a commit to denoland/deno that referenced this pull request Aug 6, 2024

BREAKING(webgpu/unstable): Replace async .requestAdapterInfo() with s…

c0e9512

…ync .info (#24783) Closes #24779 Ref gpuweb/gpuweb#4662

saschanaz mentioned this pull request Sep 16, 2024

Make GPUAdapterInfo a dictionary instead of an interface? #4876

Closed

ErichDonGubler mentioned this pull request Oct 28, 2024

Migrate from GPUAdapter.requestAdapterInfo to info member s-macke/WebGPU-Lab#3

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace asynchronous .requestAdapterInfo() with synchronous .info #4662

Replace asynchronous .requestAdapterInfo() with synchronous .info #4662

Uh oh!

kainino0x commented May 23, 2024

Uh oh!

kainino0x commented May 23, 2024

Uh oh!

toji left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mwyrzykowski commented May 29, 2024

Uh oh!

kainino0x commented May 31, 2024

Uh oh!

mwyrzykowski commented May 31, 2024 •

edited

Loading

Uh oh!

beaufortfrancois commented May 31, 2024

Uh oh!

beaufortfrancois commented Jun 3, 2024

Uh oh!

beaufortfrancois commented Jun 4, 2024 •

edited

Loading

Uh oh!

beaufortfrancois commented Sep 9, 2024

Uh oh!

mwyrzykowski commented Sep 9, 2024 •

edited

Loading

Uh oh!

mwyrzykowski commented Sep 9, 2024

Uh oh!

beaufortfrancois commented Sep 10, 2024

Uh oh!

Uh oh!

Replace asynchronous .requestAdapterInfo() with synchronous .info #4662

Replace asynchronous .requestAdapterInfo() with synchronous .info #4662

Uh oh!

Conversation

kainino0x commented May 23, 2024

Uh oh!

kainino0x commented May 23, 2024

Uh oh!

toji left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mwyrzykowski commented May 29, 2024

Uh oh!

kainino0x commented May 31, 2024

Uh oh!

mwyrzykowski commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

beaufortfrancois commented May 31, 2024

Uh oh!

beaufortfrancois commented Jun 3, 2024

Uh oh!

beaufortfrancois commented Jun 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

beaufortfrancois commented Sep 9, 2024

Uh oh!

mwyrzykowski commented Sep 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mwyrzykowski commented Sep 9, 2024

Uh oh!

beaufortfrancois commented Sep 10, 2024

Uh oh!

Uh oh!

mwyrzykowski commented May 31, 2024 •

edited

Loading

beaufortfrancois commented Jun 4, 2024 •

edited

Loading

mwyrzykowski commented Sep 9, 2024 •

edited

Loading