Remove GPUShaderModuleDescriptor.sourceMap #4840
Merged
+0
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBD exactly how we will support source maps in the future, but we realized this isn't the correct way. If there are any applications out there setting this member, this is a non-breaking change because browsers will just ignore the key. (No browsers were implementing this anyway, so at best we were just type-checking it.) History: added in 645 Fixes 4808
|
Previews, as seen when this build job started (81257ee): |
Kangz
approved these changes
Aug 29, 2024
8 tasks
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 3, 2024
This CL removes sourceMap in GPUShaderModuleDescriptor IDL file that was not used when creating a shader. Spec PR: gpuweb/gpuweb#4840 Change-Id: I1db53674eb4a58d6162aeff1cbe55cc6eec3ca38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828880 Reviewed-by: Corentin Wallez <[email protected]> Commit-Queue: Fr <[email protected]> Cr-Commit-Position: refs/heads/main@{#1350177}
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBD exactly how we will support source maps in the future, but we realized this isn't the correct way.
If there are any applications out there setting this member, this is a non-breaking change because browsers will just ignore the key. (No browsers were implementing this anyway, so at best we were just type-checking it.)
History: added in #645
Fixes #4808