Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow index < limits.maxBindGroups in getBindGroupLayout() #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Allow index < limits.maxBindGroups in getBindGroupLayout() #5042

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b9b4f0
Allow `index < limits.maxBindGroups` in `getBindGroupLayout()`
Jiawei-Shao Jan 15, 2025
f8a2c1c
Fix build error
Jiawei-Shao Jan 15, 2025
616de71
Merge branch 'main' into update-validation-getbindgrouplayout
Jiawei-Shao Jan 20, 2025
ae11dcd
Address reviewer's comments
Jiawei-Shao Jan 20, 2025
ffe2637
Merge branch 'main' into update-validation-getbindgrouplayout
Jiawei-Shao Jan 22, 2025
2ff2a23
Merge branch 'main' into update-validation-getbindgrouplayout
Jiawei-Shao Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6621,11 +6621,13 @@ pipeline, and have the following members:
[=Device timeline=] |initialization steps|:

1. Let |limits| be |this|.{{GPUObjectBase/[[device]]}}.{{device/[[limits]]}}.
1. Let |bindGroupLayouts| be a copy of |descriptor|.{{GPUPipelineLayoutDescriptor/bindGroupLayouts}}.
1. For each |i| in the [=list/get the indices|indices=] of |bindGroupLayouts|:
1. If |bindGroupLayouts|[|i|] is not `null` and
|bindGroupLayouts|[|i|].{{GPUBindGroupLayout/[[descriptor]]}}.{{GPUBindGroupLayoutDescriptor/entries}}
is [=list/empty=], set |bindGroupLayouts|[|i|] to `null`.
1. Let |bindGroupLayouts| be a [=list=] of `null` {{GPUBindGroupLayout}}s with [=list/size=]
equal to |limits|.{{supported limits/maxBindGroups}}.
1. [=list/For each=] |bindGroupLayout| at index |i| in |descriptor|.{{GPUPipelineLayoutDescriptor/bindGroupLayouts}}:
1. If |bindGroupLayout| is not `null` and
|bindGroupLayout|.{{GPUBindGroupLayout/[[descriptor]]}}.{{GPUBindGroupLayoutDescriptor/entries}}
is not [=list/empty=]:
1. Set |bindGroupLayouts|[|i|] to |bindGroupLayout|.
1. Let |allEntries| be the result of concatenating
|bgl|.{{GPUBindGroupLayout/[[descriptor]]}}.{{GPUBindGroupLayoutDescriptor/entries}}
for all non-`null` |bgl| in |bindGroupLayouts|.
Expand Down Expand Up @@ -7256,13 +7258,13 @@ interface mixin GPUPipelineBase {
<div data-timeline=device>
[=Device timeline=] |initialization steps|:

1. Let |limits| be |this|.{{GPUObjectBase/[[device]]}}.{{device/[[limits]]}}.
1. If any of the following conditions are unsatisfied
[$generate a validation error$], [$invalidate$] |layout| and return.

<div class=validusage>
- |this| must be [$valid$].
- |index| &lt; the [=list/size=] of
|this|.{{GPUPipelineBase/[[layout]]}}.{{GPUPipelineLayout/[[bindGroupLayouts]]}}
- |index| &lt; |limits|.{{supported limits/maxBindGroups}}.
</div>

1. Initialize |layout| so it is a copy of
Expand Down
Loading