-
Notifications
You must be signed in to change notification settings - Fork 337
Make imageHeight optional #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It's [awkward](https://github.com/gpuweb/cts/pull/95/files#diff-d79e5d51a5b1c3e1d586625d3f7aff62R77) to have to specify an `imageHeight` when you're not doing an array/3d texture copy (i.e. almost always). Make it default to 0 - and I would have this be valid unless `copySize.depth > 1` ... also, I still don't really like this name...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a sentence or two of spec language to explain what the default means and when it is valid?
Done (sketchily) |
I think I like having 0 indicate tightly-packed src, a la GL. No strong feelings, but I think that's easier to use. |
I'm pretty neutral, leaning very slightly toward "0 is only valid if unused". |
This was discussed in the 2020-01-06 meeting |
Resolution: update to make 0 mean tightly-packed |
Discussed again at the 2020-02-03 teleconference |
Let's talk about this at the F2F: action item @kainino0x: look up whether any native APIs allow this. |
Another alternative is to make 0 just mean "naively tightly packed", and error if that violates other restrictions. I think(?) that's what Vulkan does. |
Done: #519 (comment) |
Discussed at F2F. To be resolved by spec editors based on the input there. |
Actually, this particular item was resolved at the F2F. Updated and landing, then I'll do the rest of it as a new PR. |
It's awkward to have to specify an `imageHeight` when you're not doing an array/3d texture copy (i.e. almost always). Make it default to zero. Zero is valid iff `copySize.depth > 1`
It's awkward to have to specify an `imageHeight` when you're not doing an array/3d texture copy (i.e. almost always). Make it default to zero. Zero is valid iff `copySize.depth > 1`
It's awkward to have to specify an `imageHeight` when you're not doing an array/3d texture copy (i.e. almost always). Make it default to zero. Zero is valid iff `copySize.depth > 1`
It's awkward to have to specify an
imageHeight
when you're not doing an array/3d texture copy (i.e. almost always).Make it default to 0 - and I'd have this be valid unless
copySize.depth > 1
.... also, I still don't really like the name "imageHeight"...
Preview | Diff