Add GPUBuffer in GPUBindingResource #5193
Merged
+45
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Previews, as seen when this build job started (865c9b3): |
8 tasks
kainino0x
reviewed
May 22, 2025
kainino0x
approved these changes
May 22, 2025
Contributor
kainino0x
left a comment
There was a problem hiding this comment.
Apologies for the review delay!
Contributor
Author
|
@kainino0x Thanks for the review! I've applied your suggestion in latest commit. |
kainino0x
approved these changes
May 22, 2025
Merged
kainino0x
pushed a commit
to gpuweb/types
that referenced
this pull request
May 28, 2025
This PR reflects changes from the following spec PRs: * gpuweb/gpuweb#5193 * gpuweb/gpuweb#5160 Please publish new version after it's merged so that we can add tests in the CTS as in gpuweb/cts#4390
dneto0
pushed a commit
that referenced
this pull request
Jul 3, 2025
This PR adds GPUTexture support to the following attributes: - GPUBindingResource - GPURenderPassColorAttachment view - GPURenderPassColorAttachment resolveTarget - GPURenderPassDepthStencilAttachment view It also updates parts of the WebGPU and WGSL specs that I've missed when adding GPUBuffer in GPUBindingResource with #5193 FIX #5215 --------- Co-authored-by: Kai Ninomiya <[email protected]>
ErichDonGubler
added a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jul 17, 2025
…` r=#webgpu-reviewers! This change to upstream IDL happened at [gpuweb#5193](gpuweb/gpuweb#5193). Test coverage was added in [gpuweb/cts#4390](gpuweb/cts#4390). Differential Revision: https://phabricator.services.mozilla.com/D257634
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Jul 17, 2025
…` r=webgpu-reviewers,webidl,teoxoy,emilio This change to upstream IDL happened at [gpuweb#5193](gpuweb/gpuweb#5193). Test coverage was added in [gpuweb/cts#4390](gpuweb/cts#4390). Differential Revision: https://phabricator.services.mozilla.com/D257634
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jul 21, 2025
…` r=webgpu-reviewers,webidl,teoxoy,emilio This change to upstream IDL happened at [gpuweb#5193](gpuweb/gpuweb#5193). Test coverage was added in [gpuweb/cts#4390](gpuweb/cts#4390). Differential Revision: https://phabricator.services.mozilla.com/D257634
Chainsawkitten
added a commit
to Chainsawkitten/WebGPUReconstruct
that referenced
this pull request
Aug 4, 2025
gpuweb/gpuweb#5193 allows using GPUBuffer as a GPUBindingResource. This previously had to be done using a GPUBufferBinding.
Chainsawkitten
added a commit
to Chainsawkitten/WebGPUReconstruct
that referenced
this pull request
Aug 4, 2025
gpuweb/gpuweb#5193 allows using GPUBuffer as a GPUBindingResource. This previously had to be done using a GPUBufferBinding.
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Sep 12, 2025
This is a no-op, since wgpuReadBindGroupLayoutDescriptor() operates a statically in Wasm -> JS bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #5095