Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow GPUTexture where GPUTextureView is used #5228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dneto0 merged 10 commits into from
Jul 3, 2025
Merged

Allow GPUTexture where GPUTextureView is used #5228

dneto0 merged 10 commits into from
Jul 3, 2025

Conversation

@beaufortfrancois
Copy link
Contributor

@beaufortfrancois beaufortfrancois commented Jun 20, 2025

This PR adds GPUTexture support to the following attributes:

  • GPUBindingResource
  • GPURenderPassColorAttachment view
  • GPURenderPassColorAttachment resolveTarget
  • GPURenderPassDepthStencilAttachment view

It also updates parts of the WebGPU and WGSL specs that I've missed when adding GPUBuffer in GPUBindingResource with #5193

FIX #5215

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025 •
edited
Loading

Previews, as seen when this build job started (b3898a4):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

@beaufortfrancois beaufortfrancois mentioned this pull request Jun 24, 2025
Merged
8 tasks
@beaufortfrancois beaufortfrancois requested a review from toji June 25, 2025 13:39
toji
toji reviewed Jun 25, 2025
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed last weeks meeting so I don't know if this was agreed upon behavior. Doesn't seem like the linked issue reached a resolution, at least.

Assuming that the group has agreed on this, though, the PR looks good. Just a couple of nits.

beaufortfrancois
beaufortfrancois commented Jun 26, 2025
View reviewed changes
Copy link
Contributor Author

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toji Thanks for the review! My understanding from past meeting notes is that it had reached consensus.

toji
toji approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! WebGPU spec LGTM, but would you mind getting someone from the WGSL side (like @dneto0) to approve the WGSL spec changes?

@beaufortfrancois beaufortfrancois requested a review from dneto0 June 27, 2025 07:22
kainino0x
kainino0x reviewed Jun 28, 2025
View reviewed changes
@kainino0x kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Jul 2, 2025
kainino0x
kainino0x approved these changes Jul 2, 2025
View reviewed changes
@beaufortfrancois
Copy link
Contributor Author

beaufortfrancois commented Jul 2, 2025

@dneto0 Please review

kainino0x
kainino0x approved these changes Jul 2, 2025
View reviewed changes
toji
toji approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kai's edits LGTM.

dneto0
dneto0 approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dneto0 dneto0 merged commit e93276a into gpuweb:main Jul 3, 2025
4 checks passed
@beaufortfrancois beaufortfrancois mentioned this pull request Jul 4, 2025
Merged
@beaufortfrancois
Copy link
Contributor Author

beaufortfrancois commented Jul 4, 2025

@kainino0x Shall we update webgpu.h as well or is it only for Javascript?

@kainino0x
Copy link
Contributor

kainino0x commented Jul 7, 2025

@beaufortfrancois no, we'll do this only for Javascript. It's just an implicit .createView() and there's no issue if the C API user has to do that themselves.

@toji
Copy link
Member

toji commented Jul 7, 2025

I'm happy to do the Blink change unless this is something you wanted to tackle, @beaufortfrancois?

@beaufortfrancois
Copy link
Contributor Author

beaufortfrancois commented Jul 7, 2025

I already had one ;) Feel free to review https://chromium-review.googlesource.com/c/chromium/src/+/6656722

@beaufortfrancois beaufortfrancois mentioned this pull request Jul 10, 2025
Open
@ErichDonGubler ErichDonGubler mentioned this pull request Jul 11, 2025
Closed
@rezadzed

This comment was marked as spam.

Sign in to view
@gpuweb gpuweb deleted a comment from rezadzed Jul 13, 2025
@beaufortfrancois beaufortfrancois mentioned this pull request Jul 17, 2025
Open
4 tasks
@kainino0x kainino0x mentioned this pull request Dec 10, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kainino0x kainino0x kainino0x approved these changes

@toji toji toji approved these changes

@dneto0 dneto0 dneto0 approved these changes

Assignees

No one assigned

Labels

needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Let you pass a GPUTexture everywhere a GPUTextureView is currently used

5 participants

@beaufortfrancois @kainino0x @toji @rezadzed @dneto0