Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add size to setIndexBuffer/setVertexBuffer. #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Add size to setIndexBuffer/setVertexBuffer. #554

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32601ca
Add `size` to setIndexBuffer/setVertexBuffer.
kdashg Feb 21, 2020
78a236c
Remove comment speculating on sub-range validation.
kdashg Mar 10, 2020
dad528a
`size=0` => remaining size *after offset*.
kdashg Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2338,8 +2338,8 @@ Render Passes {#render-passes}
interface mixin GPURenderEncoderBase {
void setPipeline(GPURenderPipeline pipeline);

void setIndexBuffer(GPUBuffer buffer, optional GPUSize64 offset = 0);
void setVertexBuffer(GPUIndex32 slot, GPUBuffer buffer, optional GPUSize64 offset = 0);
void setIndexBuffer(GPUBuffer buffer, optional GPUSize64 offset = 0, optional GPUSize64 size = 0);
void setVertexBuffer(GPUIndex32 slot, GPUBuffer buffer, optional GPUSize64 offset = 0, optional GPUSize64 size = 0);

void draw(GPUSize32 vertexCount, GPUSize32 instanceCount,
GPUSize32 firstVertex, GPUSize32 firstInstance);
Expand Down Expand Up @@ -2369,6 +2369,9 @@ GPURenderPassEncoder includes GPUProgrammablePassEncoder;
GPURenderPassEncoder includes GPURenderEncoderBase;
</script>

* {{GPURenderEncoderBase/setIndexBuffer()}}/{{GPURenderEncoderBase/setVertexBuffer()}}:
* If `size` is zero, the remaining size (after `offset`) of the {{GPUBuffer}} is used.

* In indirect draw calls, the base instance field (inside the indirect
buffer data) must be set to zero.

Expand Down