Rename BGLBinding.textureDimension to viewDimension. #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Mar 4, 2020
kainino0x
approved these changes
Mar 4, 2020
JusSn
approved these changes
Mar 9, 2020
|
Discussed 2020-03-09. Resolved: accepted. |
litherum
pushed a commit
to litherum/gpuweb
that referenced
this pull request
Mar 10, 2020
13 tasks
romandev
added a commit
to romandev/cts
that referenced
this pull request
Mar 12, 2020
The member for the texture-view-dimension is of type GPUTextureViewDimension, but the name is textureDimension, which is confusing because there's also a type GPUTextureDimension[1][2]. [1] gpuweb/gpuweb#587 [2] gpuweb/gpuweb#589
romandev
added a commit
to romandev/types
that referenced
this pull request
Mar 13, 2020
The member for the texture-view-dimension is of type GPUTextureViewDimension, but the name is textureDimension, which is confusing because there's also a type GPUTextureDimension[1][2]. [1] gpuweb/gpuweb#587 [2] gpuweb/gpuweb#589
kainino0x
pushed a commit
to gpuweb/types
that referenced
this pull request
Mar 17, 2020
The member for the texture-view-dimension is of type GPUTextureViewDimension, but the name is textureDimension, which is confusing because there's also a type GPUTextureDimension[1][2]. [1] gpuweb/gpuweb#587 [2] gpuweb/gpuweb#589
kainino0x
pushed a commit
to kainino0x/cts
that referenced
this pull request
Mar 18, 2020
The member for the texture-view-dimension is of type GPUTextureViewDimension, but the name is textureDimension, which is confusing because there's also a type GPUTextureDimension[1][2]. [1] gpuweb/gpuweb#587 [2] gpuweb/gpuweb#589
kainino0x
added a commit
to gpuweb/cts
that referenced
this pull request
Mar 18, 2020
* Replace textureDimension with viewDimension The member for the texture-view-dimension is of type GPUTextureViewDimension, but the name is textureDimension, which is confusing because there's also a type GPUTextureDimension[1][2]. [1] gpuweb/gpuweb#587 [2] gpuweb/gpuweb#589 * roll types 0.0.21 -> 0.0.22 * Update test code * address comment Co-authored-by: Jinho Bang <[email protected]>
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Adds tests for destroying buffers that: - have all usages - are error buffers - are mapped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #587
Alternatively we could rename it to
textureViewDimensionbut that's a mouthful.Preview | Diff