Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename BindGroup[Layout]Binding to ...Entry #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2020
Merged

Rename BindGroup[Layout]Binding to ...Entry #590

merged 2 commits into from
Mar 9, 2020

Conversation

Kangz
Copy link
Contributor

@Kangz Kangz commented Mar 4, 2020 •
edited by pr-preview bot
Loading

kvark
kvark approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

kainino0x
kainino0x approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but the CI caught one missing rename

@kvark kvark requested a review from JusSn March 5, 2020 14:13
@kainino0x
Copy link
Contributor

Discussed 2020-03-09. Resolved: accepted.

@kainino0x kainino0x merged commit da1d4f8 into gpuweb:master Mar 9, 2020
litherum pushed a commit to litherum/gpuweb that referenced this pull request Mar 10, 2020
@Kangz @litherum
Rename BindGroup[Layout]Binding to ...Entry (gpuweb#590)
c9bf7f0
@kvark kvark mentioned this pull request Mar 11, 2020
Closed
13 tasks
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request Mar 13, 2020
@romandev
WebGPU: Rename BindGroup[Layout]Binding to -Entry
c21be58 
This is no behavior change.

Related spec change:
  gpuweb/gpuweb#590

Bug: none
Change-Id: Ie3db1eb0cd2cf61a813fd35d4f34e00af5d70f58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100947
Reviewed-by: Yuki Shiino <[email protected]>
Reviewed-by: Corentin Wallez <[email protected]>
Commit-Queue: Jinho Bang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#750069}
@kvark kvark mentioned this pull request Mar 13, 2020
Merged
@Kangz Kangz deleted the bindgroupentry branch April 21, 2020 12:02
JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Jun 8, 2020
@Kangz
Rename BindGroup[Layout]Binding to ...Entry (gpuweb#590)
018222a
JusSn pushed a commit to JusSn/gpuweb that referenced this pull request Jun 8, 2020
@Kangz
Rename BindGroup[Layout]Binding to ...Entry (gpuweb#590)
f39cc89
ben-clayton pushed a commit to ben-clayton/gpuweb that referenced this pull request Sep 6, 2022
@kainino0x
Update nonGuaranteed->required (gpuweb#590)
b559d22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

@kainino0x kainino0x kainino0x approved these changes

@kdashg kdashg kdashg approved these changes

@JusSn JusSn JusSn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kangz @kainino0x @kvark @kdashg @JusSn