Add "comparison-sampler" binding type #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kangz
reviewed
Mar 9, 2020
|
Discussed 2020-03-09. Resolved: make |
df13c38 to
f2d324c
Compare
|
@kainino0x Updated |
kvark
approved these changes
Mar 9, 2020
kainino0x
reviewed
Mar 9, 2020
Based on issue gpuweb#552, comparison samplers may not be used without specifying so on creation. This adds a new "comparison-sampler" binding type and makes the sampler compare function nullable. Comparison samplers can only be used if a compare function was specified on creation.
f2d324c to
ab75f18
Compare
kainino0x
approved these changes
Mar 9, 2020
|
I think we're set to merge this from today's meeting. |
litherum
pushed a commit
to litherum/gpuweb
that referenced
this pull request
Mar 10, 2020
Based on issue gpuweb#552, comparison samplers may not be used without specifying so on creation. This adds a new "comparison-sampler" binding type and makes the sampler compare function nullable. Comparison samplers can only be used if a compare function was specified on creation.
13 tasks
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
Based on issue gpuweb#552, comparison samplers may not be used without specifying so on creation. This adds a new "comparison-sampler" binding type and makes the sampler compare function nullable. Comparison samplers can only be used if a compare function was specified on creation.
JusSn
pushed a commit
to JusSn/gpuweb
that referenced
this pull request
Jun 8, 2020
Based on issue gpuweb#552, comparison samplers may not be used without specifying so on creation. This adds a new "comparison-sampler" binding type and makes the sampler compare function nullable. Comparison samplers can only be used if a compare function was specified on creation.
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
…eb#595) This patch adds the 3rd part of the operation tests about buffer zero initialization, including the tests on the buffers used as copy destination in copyTextureToBuffer(). * Fix a typo * Address reviewer's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on issue #552, comparison samplers may not be used without specifying
so on creation. This adds a new "comparison-sampler" binding type and makes the
sampler compare function nullable. Comparison samplers can only be used if a
compare function was specified on creation.
Preview | Diff