Disallow using image cube or cube map array texture views as storage textures #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtures This patch adds validation to disallow using cube map and cube map array texture views as storage textures as HLSL doesn't support RWTextureCube or RWTextureCubeArray, and Load() function cannot be called on TextureCube or TextureCubeArray.
Kangz
approved these changes
May 21, 2020
|
Hi WebGPU CG, I find in WebGPU we should not allow cube map and cube map array texture views being used as storage textures (read-only and write-only) and declaring In HLSL function |
kvark
approved these changes
May 21, 2020
kainino0x
approved these changes
May 21, 2020
|
Marking this as Needs Discussion just to bring it to people's attention it in the meeting. I don't think we will actually have anything to talk about. |
JusSn
approved these changes
Jun 1, 2020
|
Agreed in meeting 2020-06-01. |
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds validation to disallow using cube map and cube map array
texture views as storage textures as HLSL doesn't support RWTextureCube
or RWTextureCubeArray, and Load() function cannot be called on TextureCube
or TextureCubeArray.
Preview | Diff