Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Documenting render pass creation and descriptors #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 5, 2020
Merged

Documenting render pass creation and descriptors #831

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89efd16
Documenting render pass creation and descriptors
toji Jun 2, 2020
f440072
Update spec/index.bs
toji Jun 3, 2020
fd0ab93
Update spec/index.bs
toji Jun 3, 2020
7398b24
Addressing further feedback
toji Jun 3, 2020
1e303c3
Addressing remaining feedback
toji Jun 4, 2020
ae64f57
Hopefully last pass at feedback updates
toji Jun 5, 2020
16cf4fc
Apply suggestions from code review
kainino0x Jun 5, 2020
9e21ed0
add GPUTextureView.[[texture]] from #838
kainino0x Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Addressing further feedback
  • Loading branch information
@toji
toji committed Jun 3, 2020
commit 7398b248dbed5a710f024a1bc840168e159afaa3
21 changes: 20 additions & 1 deletion spec/index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3951,6 +3951,8 @@ dictionary GPURenderPassDescriptor : GPUObjectDescriptorBase {

Given a {{GPURenderPassDescriptor}} |this| the following validation rules apply:

1. |this|.{{GPURenderPassDescriptor/colorAttachments}}.length must be less than or equal to the
[=maximum color attachments=].
1. |this|.{{GPURenderPassDescriptor/colorAttachments}}.length must greater than `0` or
|this|.{{GPURenderPassDescriptor/depthStencilAttachment}} must not be `null`.
1. For each |colorAttachment| in |this|.{{GPURenderPassDescriptor/colorAttachments}}:
Expand All @@ -3960,6 +3962,14 @@ dictionary GPURenderPassDescriptor : GPUObjectDescriptorBase {
1. If |this|.{{GPURenderPassDescriptor/depthStencilAttachment}} is not `null`:

1. |this|.{{GPURenderPassDescriptor/depthStencilAttachment}} must meet the [$GPURenderPassDepthStencilAttachmentDescriptor/Valid Usage|GPURenderPassDepthStencilAttachmentDescriptor Valid Usage$] rules.

1. Each {{GPURenderPassColorAttachmentDescriptor/attachment}} in |this|.{{GPURenderPassDescriptor/colorAttachments}}
and |this|.{{GPURenderPassDescriptor/depthStencilAttachment}}.{{GPURenderPassDepthStencilAttachmentDescriptor/attachment}},
if present, must have all have the same {{GPUTexture/[[sampleCount]]}}.

Issue: Define <dfn>maximum color attachments</dfn>

Issue(gpuweb/gpuweb#503): support for no attachments
</div>

#### Color Attachments #### {#color-attachments}
Expand Down Expand Up @@ -4002,11 +4012,16 @@ dictionary GPURenderPassColorAttachmentDescriptor {
apply:

1. |this|.{{GPURenderPassColorAttachmentDescriptor/attachment}} must have a renderable color format.
1. |this|.{{GPURenderPassColorAttachmentDescriptor/attachment}}.{{GPUTexture/[[textureUsage]]}} must contain {{GPUTextureUsage/OUTPUT_ATTACHMENT}}.
1. If |this|.{{GPURenderPassColorAttachmentDescriptor/resolveTarget}} is not `null`:

1. |this|.{{GPURenderPassColorAttachmentDescriptor/attachment}} must be multisampled.
1. |this|.{{GPURenderPassColorAttachmentDescriptor/resolveTarget}} must not be multisampled.
1. Issue: Describe the remainder of resolveTarget validation
1. |this|.{{GPURenderPassColorAttachmentDescriptor/resolveTarget}}.{{GPUTexture/[[textureSize]]}}
must match |this|.{{GPURenderPassColorAttachmentDescriptor/attachment}}.{{GPUTexture/[[textureSize]]}}.
1. |this|.{{GPURenderPassColorAttachmentDescriptor/resolveTarget}}.{{GPUTexture/[[format]]}}
must match |this|.{{GPURenderPassColorAttachmentDescriptor/attachment}}.{{GPUTexture/[[format]]}}.
1. Issue: Describe any remaining resolveTarget validation

1. Otherwise |this|.{{GPURenderPassColorAttachmentDescriptor/attachment}} must not be multisampled.

Expand Down Expand Up @@ -4067,6 +4082,10 @@ dictionary GPURenderPassDepthStencilAttachmentDescriptor {
rules apply:

1. |this|.{{GPURenderPassDepthStencilAttachmentDescriptor/attachment}} must have a renderable depth-and/or-stencil format.
1. |this|.{{GPURenderPassDepthStencilAttachmentDescriptor/depthReadOnly}} is `true`,
|this|.{{GPURenderPassDepthStencilAttachmentDescriptor/depthLoadValue}} must be {{GPULoadOp/"load"}}.
1. |this|.{{GPURenderPassDepthStencilAttachmentDescriptor/stencilReadOnly}} is `true`,
|this|.{{GPURenderPassDepthStencilAttachmentDescriptor/stencilLoadValue}} must be {{GPULoadOp/"load"}}.

Issue: Describe the remaining validation rules for this type.
</div>
Expand Down