Document compute pass creation #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kangz
approved these changes
Jun 8, 2020
JusSn
approved these changes
Jun 8, 2020
kainino0x
reviewed
Jun 8, 2020
|
Given that this has three approvals now and @kainino0x's comments don't prescribe any changes, can we merge this? I'm happy to do it myself, but have been told that self merges are not the norm on this repo. |
|
One fewer thing to do in the editors meeting in 5 min :) |
ben-clayton
pushed a commit
to ben-clayton/gpuweb
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, since this was far simpler than the render pass equivalent, took the oppornutity to address the validation name conflicts pointed out by @kainino0x
Preview | Diff