Implement WebGPUTextureViewDescriptor #90
Conversation
f64c3f7 to
201b323
Compare
| "3d" | ||
| }; | ||
|
|
||
| dictionary WebGPUTextureViewDescriptor { |
There was a problem hiding this comment.
we'll need aspects from #89 here so probably makes sense to wait for it first
There was a problem hiding this comment.
It sounds like we might want to use a special format for this as mentioned in #79 ?
There was a problem hiding this comment.
I think another choice is to add a flag to specify which part (color, depth or stencil) is covered in the texture view (like the aspectMask in VkImageSubresourceRange).
| }; | ||
|
|
||
| interface WebGPUTexture { | ||
| WebGPUTextureView createTextureView(WebGPUTextureViewDescriptor desc); |
There was a problem hiding this comment.
Maybe we want to have createTextureView be on the device so that WebGPUTexture is a opaque handle and that's it. WDYT?
There was a problem hiding this comment.
I was considering that as well when reviewing. And my initial reaction was: it's fine:
- Vulkan and D3D12 devices are internally synchronized, so the
WebGPUTextureimplementation can just carry a pointer to one. No performance overhead from this. - Metal already has the view creation on
MTLTextureitself. - Slightly cleaner (and more user friendly) API
WebGPUTextureis an interface anyway. Is there a benefit from it being empty, e.g. for WASM host bindings proposal?
There was a problem hiding this comment.
I have moved createTextureView to WebGPUDevice. PTAL, thanks!
There was a problem hiding this comment.
@kvark agreed that it doesn't make a big difference and there's no special benefits to WebGPUTexture being an empty interface. I don't really mind either way so maybe we can keep it in texture and bikeshed later?
@Jiawei-Shao sorry for the churn on this and https://dawn-review.googlesource.com/c/dawn/+/1580 can you rollback the changes?
d5aab70 to
00e3457
Compare
00e3457 to
d3b8aee
Compare
This patch adds the definition of WebGPUTextureViewDimension and the required members in WebGPUTextureViewDescriptor according to the proposal gpuweb#79.
d3b8aee to
d3d7d23
Compare
|
Done |
|
I think there's been enough time for anyone to look at the code, and there isn't much of it anyway. Merging |
This patch adds the definition of WebGPUTextureViewDimension and
the required members in WebGPUTextureViewDescriptor according to
the proposal #79.