Alerting: Fix flaky TestIntegrationHAEvaluation#119367
Draft
alexander-akhmetov wants to merge 1 commit intomainfrom
Draft
Alerting: Fix flaky TestIntegrationHAEvaluation#119367alexander-akhmetov wants to merge 1 commit intomainfrom
alexander-akhmetov wants to merge 1 commit intomainfrom
Conversation
Previously, TestIntegrationHAEvaluation_SingleNodeEvaluates captured one initial evaluation count per node and then expected non-primary nodes to never go above it. But during startup, a non-primary node can briefly evaluate before peer positions settle. This change checks evaluation delta over a short time window instead of comparing to a single startup baseline. It asserts that only the position=0 node increases evaluations in that window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestIntegrationHAEvaluation_SingleNodeEvaluatescaptured one initial evaluation count per node and then expected non-primary nodes to never go above it. But during startup, a non-primary node can briefly evaluate before peer positions settle. This change checks evaluation delta over a short time window instead of comparing to a single startup baseline. It asserts that only the position=0 node increases evaluations in that window.